Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] build error (#819) #820

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

oldnick85
Copy link
Contributor

add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -11,6 +11,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <stddef.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got lost during PR #778. The change here looks good to me.

Since we need this header (so far) only because of "offsetof" that is only in this C file, it could simply be included here, but I will let @levb decide if he would rather have it in "glibp.h".

Copy link
Collaborator

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit f20f247 into nats-io:main Dec 3, 2024
20 checks passed
levb pushed a commit to levb/nats.c that referenced this pull request Dec 9, 2024
add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

Co-authored-by: oldnick85 <[email protected]>
@levb levb removed the cherry-pick label Dec 9, 2024
@levb
Copy link
Collaborator

levb commented Dec 9, 2024

Cherry-picked into v3.9.2

@oldnick85 oldnick85 deleted the add_stddef_header branch December 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants