Revert 192 #200
Merged
Revert 192 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleblloyd
force-pushed
the
revert-192
branch
3 times, most recently
from
19db775
to
73992f0
Compare
caleblloyd
commented
May 31, 2024
Signed-off-by: Caleb Lloyd <[email protected]>
suckatrash
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #192
There are some edge cases where Surveyor can reload and routes can be re-indexed in a different order, leading to false spikes. Best to go back to using the unique RID here
This change was un-released so should not affect anyone unless they are running of
main