Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Documentation and Typographical Fixes for NATS Server #6357

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

MarsonKotovi4
Copy link
Contributor

• Corrected typos and grammatical errors in documentation.
• Improved text clarity and accuracy across README, CONTRIBUTING, and other files.
• Updated wording for better readability and a more professional tone.

@MarsonKotovi4 MarsonKotovi4 requested a review from a team as a code owner January 9, 2025 16:35
TODO.md Outdated
@@ -10,7 +10,7 @@
- [ ] _SYS. server events?
- [ ] No downtime restart
- [ ] Signal based reload of configuration
- [ ] brew, apt-get, rpm, chocately (windows)
- [ ] brew, apt-get, rpm, chocateley (windows)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be

Suggested change
- [ ] brew, apt-get, rpm, chocateley (windows)
- [ ] brew, apt-get, rpm, chocolatey (windows)

Co-authored-by: Waldemar Quevedo <[email protected]>
@MarsonKotovi4
Copy link
Contributor Author

@wallyqs check pls

@MarsonKotovi4
Copy link
Contributor Author

@wallyqs delete TODO.md

@MarsonKotovi4
Copy link
Contributor Author

@wallyqs

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should squash into one commit

@MarsonKotovi4
Copy link
Contributor Author

LGTM, следует объединить в один коммит

I have two tests failing in my PR that are likely unrelated to my documentation changes:

  1. TestJetStreamClusterGhostEphemeralsAfterRestart – failing with a data race error.
  2. TestClosedConnsSubsAccounting – expects 1 closed connection but sees 0.

It looks like these might be flaky tests. Could you please take a look and consider rerunning or advising on how to proceed? Thanks!

@derekcollison derekcollison merged commit 4060845 into nats-io:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants