Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare benchmarks for memory streams #6318

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

MauriceVanVeen
Copy link
Member

Benchmarks like BenchmarkJetStreamPublish would fail when changed to use memory-based storage with the following message:

BenchmarkJetStreamPublish/N=3,R=3,MsgSz=1024b,Subjs=1/Async[W:4000]
    jetstream_benchmark_test.go:738: Publish timed out

This was due to the underlying error being hit:

Apply stream entries for '$G > S' got error processing message: insufficient resources (10023)

Making the maximums consistent so all file-based benchmarks/tests can also run for memory-based without timing out due to insufficient resources.

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner January 3, 2025 12:49
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit b49ed3c into main Jan 6, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/bench-memory branch January 6, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants