ADR-45 - Testing flow for long-running server tests #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprimi
requested review from
ripienaar,
neilalexander,
ReubenMathew and
Jarema
wallyqs
reviewed
Sep 16, 2024
Co-authored-by: Waldemar Quevedo <[email protected]>
ReubenMathew
suggested changes
Sep 17, 2024
|
I think it's a useful approach and worth doing but not sure it merits an ADR - we tend to use these for big design things not for decisions |
|
I'd like to see a test design doc instead of references to code, and I think that does belong here. I might remove the server category to keep it distinct as testing. |
Co-authored-by: Reuben <[email protected]>
Fair enough. I won't try to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.