Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-demand reconnect to Connect Spec #258

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 3, 2024

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema Jarema requested a review from ripienaar January 3, 2024 14:05
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we provide any indication of what it should be called like Reconnect() or just entirely up to the lang dev?

@Jarema
Copy link
Member Author

Jarema commented Jan 4, 2024

Good point. Added a comment.

Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 5ba70d7 into main Jan 4, 2024
1 check passed
@Jarema Jarema mentioned this pull request Jan 4, 2024
13 tasks
@scottf scottf deleted the add-reconnect-on-demand branch June 26, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants