Add connection spec draft #247
Conversation
spec/connection.md
Outdated
|
|
||
| ### Error Handling (TODO) | ||
|
|
||
| Server can respond with `Authorization Error`. |
There was a problem hiding this comment.
discuss the specific way in which this is handled - if it terminates retries or not
spec/connection.md
Outdated
| ### Servers discovery | ||
|
|
||
| When Server sends back [INFO][INFO]. It may contain additional URLs to which the client can make connection attempts. | ||
| The client should store those URLs and use them in the Reconnection Strategy. |
There was a problem hiding this comment.
True, but again only if clients are sending "protocol: 1" (or above) in the CONNECT protocol.
|
@kozlovic addressed / responded to all comments. Thanks for a thorough review! |
spec/connection.md
Outdated
|
|
||
| |Revision|Date|Author|Info| | ||
| |--------|----|------|----| | ||
| |1 |2023-10-12|@author|Initial draft| |
There was a problem hiding this comment.
formatting and extra spaces here, @author is also wrong
spec/connection.md
Outdated
|
|
||
| When the client detects disconnection, it starts to reconnect attempts with the following rules: | ||
| 1. Immediate reconnect attempt | ||
| The client attempts to reconnect immediately after finding out it has been disconnected. |
There was a problem hiding this comment.
Should this really be 2 lines? Or maybe a leading - is missing looking at other lines here
adr/ADR-40.md
Outdated
| | Date | 2023-10-12 | | ||
| | Author | @Jarema | | ||
| | Status | Implemented | | ||
| | Tags | spec | |
There was a problem hiding this comment.
I'd keep the client, server here, so it shows up in those sections also for people to find. It's not just a spec, its related to multiple things?
There was a problem hiding this comment.
Think you should also run go run main.go > README.md
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
add-connection-spec
branch
from
2bc5792 to
1ff325c
Compare
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
README.md
Outdated
| |[ADR-8](adr/ADR-8.md)|jetstream, client, kv, spec|JetStream based Key-Value Stores| | ||
| |[ADR-32](adr/ADR-32.md)|client, spec|Service API| | ||
| |[ADR-37](adr/ADR-37.md)|jetstream, client, spec|JetStream Simplification| | ||
| |[ADR-40](adr/ADR-40.md)|spec|NATS Connection| |
|
wow ADR-40 is a really valuable addition! if I may chip in with 5c : it would be nice to describe how NATS "Core" requests and higher-level functions like JS
I managed to find out some of this info from nats.go unit tests, but not everything... so ended up writing my own summary :D |
This PR uses the more holistic approach to describe NATS features and server-client interactions.
It is not complete description for Connection, rather a work in progress, focused on
tls_first, as this needed spec.Signed-off-by: Tomasz Pietrek [email protected]