tests for global.image.pullSecretNames #815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #814
Changes un-released
global.image.pullSecrets
toglobal.image.pullSecretNames
This is because
imagePullSecrets
takes an array of{name: secretName}
objectsI thought it was better to be more specefic that we are only taking the
secretName
portion inpullSecretNames
, and we are adding thename:
keyThis is consistent with the use of
secretName
many other places in the chart values