Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for global.image.pullSecretNames #815

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

caleblloyd
Copy link
Contributor

Tests for #814

Changes un-released global.image.pullSecrets to global.image.pullSecretNames

This is because imagePullSecrets takes an array of {name: secretName} objects

I thought it was better to be more specefic that we are only taking the secretName portion in pullSecretNames, and we are adding the name: key

This is consistent with the use of secretName many other places in the chart values

@caleblloyd
Copy link
Contributor Author

/cc @adberger

Signed-off-by: Caleb Lloyd <[email protected]>
@adberger
Copy link
Contributor

adberger commented Nov 1, 2023

/cc @adberger

I'm fine with that, thanks.
Just FYI the other helm charts also don't seem to template name automatically.

Signed-off-by: Caleb Lloyd <[email protected]>
@caleblloyd caleblloyd merged commit b85689c into main Nov 2, 2023
@caleblloyd caleblloyd deleted the image-pull-secret-names-tests branch November 2, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants