Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlogPage custom_type_label #1782

Merged
merged 12 commits into from
Jan 29, 2025
Merged

BlogPage custom_type_label #1782

merged 12 commits into from
Jan 29, 2025

Conversation

jamesbiggs
Copy link
Collaborator

About these changes

Adds a chip_override field on BlogPages so that we can set the type_label for any child BlogPostPages. This is only used on the top level blogs, so any child BlogPages attempts to override will be ignored.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs requested a review from ahosgood January 23, 2025 12:40
@jamesbiggs jamesbiggs changed the title BlogPage chip_override BlogPage custom_type_label Jan 28, 2025
@jamesbiggs jamesbiggs requested a review from ahosgood January 28, 2025 14:47
@jamesbiggs jamesbiggs merged commit 816525c into develop Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants