-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deezer alternative track #700
base: dev
Are you sure you want to change the base?
Conversation
Thanks. Can you make sure the ruff checks pass? |
Ah, nice, didn't notice the ruff tests yelling at me 😄. Ok, done |
I don't understand the meaning of ruff's test result, which is rather cryptic. I understand that it complains about file formatting, but i don't know what is expected. Can you give me a hint ? |
Run |
Ok I fixed formatting and some minor issues. Can you verify that it still works with the broken track URL? Also, can you please provide the URL that doesn't work here for the record? |
Sorry for the very late response : I had no time to test lately. And now that I have a couple of hours to test, my python environment is totally messed up. Grrrr, I will keep for myself what I think of python, and try to have it back in a working state. |
Track IDs on deezer are updated quite frequently, because of some obscure track duplication. And the old version is not playable anymore. When you listen to a playlist, it contains the old identifiers, but you don't notice because the deezer interface manages to retrieve the new track version anyway.
But when streamrip retrieves the track list from a playlist, it ends up with the wrong identifiers.
This PR covers the modifications made to get around the problem (#638), in the following order of preference:
During this process, log messages are sent to the console (WARNING if alternative found, ERROR if no alternative is found).