Merge pull request #42 from natemoo-re/fix/attr-newlines

Handle attributes with linebreaks

.changeset/perfect-buckets-add.md

@@ -0,0 +1,5 @@
+---
+"ultrahtml": patch
+---
+
+Update attribute handling to account for attributes with newlines

src/index.ts

@@ -101,7 +101,7 @@ const VOID_TAGS = new Set<string>([
   "wbr",
 ]);
 const RAW_TAGS = new Set<string>(["script", "style"]);
-const SPLIT_ATTRS_RE = /([\@\.a-z0-9_\:\-]*)\s*?=?\s*?(['"]?)(.*?)\2\s+/gim;
+const SPLIT_ATTRS_RE = /([\@\.a-z0-9_\:\-]*)\s*?=?\s*?(['"]?)([\s\S]*?)\2\s+/gim;
 const DOM_PARSER_RE =
   /(?:<(\/?)([a-zA-Z][a-zA-Z0-9\:-]*)(?:\s([^>]*?))?((?:\s*\/)?)>|(<\!\-\-)([\s\S]*?)(\-\->)|(<\!)([\s\S]*?)(>))/gm;
 

test/basic.test.ts

@@ -70,4 +70,26 @@ describe("attributes", () => {
     } = parse(`<div test a="b" c="1"></div>`);
     expect(attributes).toMatchObject({ test: "", a: "b", c: "1" });
   });
+  it("with linebreaks", async () => {
+    const {
+      children: [{ attributes }],
+    } = parse(`<div a="1
+2
+3"></div>`);
+    expect(attributes).toMatchObject({ a: "1\n2\n3" });
+  });
+  it("with single quote", async () => {
+    const {
+      children: [{ attributes }],
+    } = parse(`<div a="nate'
+s"></div>`);
+    expect(attributes).toMatchObject({ a: "nate'\ns" });
+  });
+  it("with escaped double quote", async () => {
+    const {
+      children: [{ attributes }],
+    } = parse(`<div a="\"never
+more\""></div>`);
+    expect(attributes).toMatchObject({ a: "\"never\nmore\"" });
+  });
 });