-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade all Dependencies and resolve any breaking changes #16
Conversation
…reorganized repo for new version of astro and to keep the actual package separate from the demo/playground. more still to do.
…l be ready to test!
🦋 Changeset detectedLatest commit: 5f11cf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…de from keeping JavaScript out of the project
Thanks! I'm going to give this a thorough review in a few hours and try to figure out what's up with the CI checks. |
…eed update to sister package ultrahtml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for jumping in and tackling this!
I left a pretty thorough review and tried to explain my thinking on API decisions. The one important conversation for us to resolve is if this is actually worthy of a major
release. According to the Semantic Versioning specification, "[m]ajor version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable." and it's best practice to introduce breaking changes in a minor
release during this phase.
Since we're working on stability and improvements, I would argue that this package isn't quite ready for a stable v1 just yet.
dcd6739
to
a916309
Compare
…reorganized repo for new version of astro and to keep the actual package separate from the demo/playground. more still to do.
…l be ready to test!
…de from keeping JavaScript out of the project
…eed update to sister package ultrahtml
a916309
to
850721e
Compare
… users directly in their code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, super excited to get this out! Thanks for all the hard work 🔥
This PR will upgrade ALL the Dependencies as well as resolve any formatting issues that were caused do to this update(i.e
transform
fromultrahtml
changing the format oftransformers
from{}
to[]
)