Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade all Dependencies and resolve any breaking changes #16

Merged
merged 38 commits into from
Feb 26, 2024

Conversation

Adammatthiesen
Copy link
Collaborator

This PR will upgrade ALL the Dependencies as well as resolve any formatting issues that were caused do to this update(i.e transform from ultrahtml changing the format of transformers from {} to [])

@Adammatthiesen Adammatthiesen linked an issue Feb 16, 2024 that may be closed by this pull request
@Adammatthiesen Adammatthiesen linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 5f11cf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-remote Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Adammatthiesen Adammatthiesen marked this pull request as ready for review February 16, 2024 09:15
@Adammatthiesen Adammatthiesen linked an issue Feb 18, 2024 that may be closed by this pull request
@natemoo-re
Copy link
Owner

Thanks! I'm going to give this a thorough review in a few hours and try to figure out what's up with the CI checks.

Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for jumping in and tackling this!

I left a pretty thorough review and tried to explain my thinking on API decisions. The one important conversation for us to resolve is if this is actually worthy of a major release. According to the Semantic Versioning specification, "[m]ajor version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable." and it's best practice to introduce breaking changes in a minor release during this phase.

Since we're working on stability and improvements, I would argue that this package isn't quite ready for a stable v1 just yet.

.changeset/shiny-dingos-remember.md Outdated Show resolved Hide resolved
.changeset/shiny-dingos-remember.md Outdated Show resolved Hide resolved
.changeset/shiny-dingos-remember.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package/LICENSE Outdated Show resolved Hide resolved
package/lib/Markdown.astro Outdated Show resolved Hide resolved
package/lib/Markdown.astro Outdated Show resolved Hide resolved
package/lib/utils.ts Outdated Show resolved Hide resolved
package/package.json Outdated Show resolved Hide resolved
pnpm-workspace.yaml Outdated Show resolved Hide resolved
natemoo-re
natemoo-re previously approved these changes Feb 26, 2024
Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, super excited to get this out! Thanks for all the hard work 🔥

packages/astro-remote/README.md Outdated Show resolved Hide resolved
packages/astro-remote/README.md Outdated Show resolved Hide resolved
packages/astro-remote/README.md Outdated Show resolved Hide resolved
packages/astro-remote/lib/utils.ts Outdated Show resolved Hide resolved
natemoo-re
natemoo-re previously approved these changes Feb 26, 2024
@natemoo-re natemoo-re merged commit 643f9b8 into main Feb 26, 2024
1 check passed
@Adammatthiesen Adammatthiesen deleted the adam-upgrade branch February 26, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws error when building. Using marked extension Install command missing in README
2 participants