Refactor (Option::type) More consistant constants #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2018 14:01
Add class for holding constants which are common accross classes and performing simple value operations and comparisons. DEPRECATE the current constants, which are similar but use different naming and values to mean the same thing in other classes. BREAKING: The original constant values used in the Command class have changed. - Add enumerator class to contain Option type constant values along with some utility functions for comparing types. - Replace constant values with those from TypeEnum in Option - Replace constant values with those from TypeEnum in Command - Add dependency for systems without SplTypes PECL extension - Tests for new class *_Deprecated:_* - Option::TYPE_SHORT - Option::TYPE_VERBOSE - Option::TYPE_NAMED - Option::TYPE_ANONYMOUS - Command::OPTION_TYPE_SHORT - Command::OPTION_TYPE_VERBOSE - Command::OPTION_TYPE_ARGUMENT
- Replace ::class since this was introduced in 5.5 - Constants could not be declared with expressions until 5.6
Use explicit class name as string for is_subclass_of
|
I created a PHP 5.4-7.1 version of this and then a PHP 7.2 version: https://github.com/tolidano/commandox/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add class for holding constants which are common accross classes
and performing simple value operations and comparisons. DEPRECATE
the current constants, which are similar but use different naming
and values to mean the same thing in other classes.
BREAKING: The original constant values used in the Command class
have changed.
with some utility functions for comparing types.
Deprecated: