Events improved error handling#88 #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and markup. - Handled error when the URL that is fetched fails and the Promise is not resolved properly - Handled error where the fetch returns an empty promise and the events are empty - Added loading spinner - Changed the style of the events section, so that grid layout is not applied to loading and error elements - Added a state (in index.js) to track the status of the promise returned from pingEvents.js
- changed how comments are placed - added back in the Connect logo container, so that the Connect logo is aligned with the main content on the site. If this is an issue it can be removed, but my build has had no issues with this. - changed how we determine online vs in-person events. Checks against commonly used strings to determine if the event is in-person.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
pingEventsfunction.okbut the events list is empty, then we timeout and set the status of the events toerrorreact-spinnerslibrary and added a loading spinner, so that users get a visual cue during events loading.connect-logo-containerclass which centers the connect logo with the main content. This can be removed if it causes issues, however I have yet to find any.How can I test this?
npm installto install needed dependencies.netlifyin your console. If not typenpm install netlify-cli -gin the console to install it.'http://localhost:8888/.netlify/functions/pingEvents'to access the Netlify function.netlify devto start the development server.localhost:8000to see the spinner and error timeout occur.