-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE: Performance Improvement - Optimize Site Images #99 #108
Conversation
Open - Created AVIF versions of all SVG files in src/images
I'm pretty sure I did not perform the commit process correctly. Sorry about that! I converted the SVG files in src/images to AVIF which I believe is what you're looking for in issue #99 as a part of Hacktoberfest. Hopefully this is helpful for y'all. |
Thank you for updating those images. You did great and I fixed the PR. No problem. 👍 👏 Unfortunately, after reading up on AVIF files. It seems that Gatsby version 2 doesn't support AVIF files but Gatsby 3 does. I like the idea of using AVIF images. We do have a ticket for upgrading to Gatsby 3 if you are interested. Ticket #101 would allow us to AVIF files. Note: Ticket #101 is also a Hacktoberfest ticket❗ Link to Blog Post about Gatsby 3 image formats for context: |
Hi, I want to chime in a bit about the PR.
However, the most programmatic solution is using gatsby-image (deprecated) or the recommend gatsby-image-plugin. They will handle the transformation automatically, and many other optimizations. |
I see your point. We should use |
Hey guys, I hate to be the bearer of bad news but we had another PR someone submitted for this same issue: PR #115 Also, I think we needed to groom that issue better because, from what I can see, gatbsy-image and its related plugins are designed for raster images. These SVGs can be minified or converted to other formats, but they're already small and it's not a big bottleneck for us. I'm going to close out this issue in a couple days if there's no further conversation. Thanks for the contributions, everyone! It was a good effort, and a good solution, but we should have specified better in the original issue. |
Added the |
Open - Created AVIF versions of all SVG files in src/images