Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad color value for Gauge 'Needle' type #7821

Merged
merged 8 commits into from
Sep 28, 2024
Merged

Conversation

charlesh88
Copy link
Contributor

Closes #7820

  • Fix 0 opacity fill in theme constants files for Gauge type needle.
  • Theme constants in Espresso, Snow and Maelstrom fixed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? N/A
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Fix 0 opacity fill in theme constants files for Gauge type needle.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (a8fbabe) to head (052ce57).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7821      +/-   ##
==========================================
- Coverage   57.23%   56.96%   -0.28%     
==========================================
  Files         675      675              
  Lines       27287    27287              
  Branches     2671     2671              
==========================================
- Hits        15618    15543      -75     
- Misses      11333    11408      +75     
  Partials      336      336              
Flag Coverage Δ
e2e-ci 61.81% <ø> (+0.04%) ⬆️
e2e-full 23.51% <ø> (-18.39%) ⬇️
unit 49.35% <ø> (ø)

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fbabe...052ce57. Read the comment docs.

@ozyx ozyx added this to the Target:4.0.1 milestone Aug 28, 2024
@akhenry akhenry requested review from unlikelyzero and removed request for ozyx September 5, 2024 17:05
@akhenry
Copy link
Contributor

akhenry commented Sep 5, 2024

@jvigliotta to review
@unlikelyzero to update visual test

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward!

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 11, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 11, 2024
@davetsay
Copy link
Contributor

@unlikelyzero to write visual test

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2024
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2024
@unlikelyzero unlikelyzero merged commit c498f7d into master Sep 28, 2024
22 of 23 checks passed
@unlikelyzero unlikelyzero deleted the gauge-needle-7820 branch September 28, 2024 16:17
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gauge type Needle Dial not working
6 participants