-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expanded view for Time List #7378
Merged
Merged
Changes from 58 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
7003f00
Add activity states domain object and interceptor to auto create one
shefalijoshi 92a30a3
Add activity state inspector option
shefalijoshi 4d4f83e
Only save status if we have a unique ids for activities
shefalijoshi 02edb99
Include the id in the activity properties
shefalijoshi e47bfed
Don't show activity state section in the inspector if multiple activi…
shefalijoshi 3c14025
Display activity properties when an activity row is selected in the t…
shefalijoshi 2e41753
Add compact view for timelist
shefalijoshi c6a6a18
Add inspector configuration for compact view
shefalijoshi a0ccc4e
Set colors based on time relation of activity
shefalijoshi 65a7e7e
Use activity id as key if it is available
shefalijoshi 176d344
Ensure the correct option is selected for activity states
shefalijoshi 9ff31d5
Closes #7377
charlesh88 ad07174
Closes #7377
charlesh88 02c796a
Add status label
shefalijoshi 44f4ac2
Rename to Expanded view and isExpanded as properties. Add display sty…
shefalijoshi b0a21d4
Refactor activity selection. Display activity properties
shefalijoshi 3655ba9
Closes #7377
charlesh88 3365039
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 5cbd0fd
Closes #7377
charlesh88 dc1def5
Remove activity states plugin. Move the activity states interceptor t…
shefalijoshi b413a9b
Change activity states interceptor parameters to options
shefalijoshi bbf5454
Rename constants
shefalijoshi 6def4c2
Fix activity states test
shefalijoshi 9b85252
Merge branch 'master' of https://github.com/nasa/openmct into activit…
shefalijoshi 51e20ea
Addresses review comments making code more readable.
shefalijoshi 95d7488
Closes #7377
charlesh88 585b60d
Closes #7377
charlesh88 15acbc9
Remove ExpandedView component and pull the ExpandedViewItem up to the…
shefalijoshi dcad88c
Merge branch 'master' into timelist-compact-view
shefalijoshi e209b00
Fix sorting for compact view.
shefalijoshi 3bd09fc
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi 5908f96
Merge branch 'master' into activity-state-display
shefalijoshi 34c1f20
Closes #7377
charlesh88 e6fb968
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 6682d00
Closes #7377
charlesh88 78f2852
Add e2e test for activity states feature.
shefalijoshi 5c6a733
Address review comments. Rename variables, documentation.
shefalijoshi 42ed592
No shallow copy
shefalijoshi 7931d4b
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi b5a73d3
Merge branch 'activity-state-display' of https://github.com/nasa/open…
shefalijoshi 6ac08b0
Merge updates to activity-state
shefalijoshi 8798aa1
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi 6ae216d
Sync with activity states PR
shefalijoshi c51f828
Draft of progress-pie
shefalijoshi 3e0342a
- Add `s-selected` styling for Expanded Time List elements.
charlesh88 21f6279
Add 2 new date formats
shefalijoshi 6116662
Look and feel enhancements for pie, zero duration events and start an…
shefalijoshi e74be9b
Fix pie show/hide condition
shefalijoshi 9ceb8a6
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 9f7d931
Final touches to the pie and labels
shefalijoshi eb80bcb
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 a0aa1c9
Refactor label logic
shefalijoshi d9a50b4
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 884373e
Closes #7377
charlesh88 9e00836
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi a56931e
Remove use of ListView - no point passing arrays around since we are …
shefalijoshi bb74f21
We addded a new column for duration and changed the previous duration…
shefalijoshi 905801c
Fix expanded view for timelist tests
shefalijoshi 088b4b0
Closes #7377
charlesh88 91a2c62
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 3ad4acf
Merge branch 'master' into timelist-compact-view
charlesh88 af161f9
Closes #7377
charlesh88 a9feb37
Optimize rendering of timelist activities
shefalijoshi 32781e2
Remove focused test
shefalijoshi e248c78
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi a09522d
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi 333b683
Address review comments
shefalijoshi 1bf5a15
Remove reactive selection for plan activities
shefalijoshi 004957d
destructure props into individual item properties for render performa…
shefalijoshi ac80da4
Merge remote-tracking branch 'origin' into timelist-compact-view
charlesh88 6026876
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi 73c2e7e
Use local variables and remove JSON utility methods
shefalijoshi c03d7bb
Change cancelled to skipped
shefalijoshi c45c6a2
Focus the activity tab when shown
shefalijoshi f068090
Fix label updates
shefalijoshi 14ede06
Merge branch 'master' into timelist-compact-view
shefalijoshi fbd271a
Add countup to cspell
shefalijoshi fb38cdb
Remove progress pie due to licensing unknowns
shefalijoshi 5cfa222
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,278 @@ | ||
<!-- | ||
Open MCT, Copyright (c) 2014-2024, United States Government | ||
as represented by the Administrator of the National Aeronautics and Space | ||
Administration. All rights reserved. | ||
|
||
Open MCT is licensed under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0. | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
License for the specific language governing permissions and limitations | ||
under the License. | ||
|
||
Open MCT includes source code licensed under additional open source | ||
licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
this source code distribution or the Licensing information page available | ||
at runtime from the About dialog for additional information. | ||
--> | ||
<template> | ||
<div :class="listItemClass" role="row"> | ||
<div class="c-tli__activity-color"> | ||
<div class="c-tli__activity-color-swatch" :style="styleClass"></div> | ||
</div> | ||
<div class="c-tli__title-and-bounds"> | ||
<div class="c-tli__title">{{ formattedItem.title }}</div> | ||
<div class="c-tli__bounds" :class="{ '--has-duration': eventHasDuration }"> | ||
<div v-if="eventHasDuration" class="c-tli__duration">{{ formattedItem.duration }}</div> | ||
<div v-else class="c-tli__start-time">Event</div> | ||
<div class="c-tli__start-time"> | ||
{{ formattedItem.start }} | ||
</div> | ||
<div v-if="eventHasDuration" class="c-tli__end-time">{{ formattedItem.end }}</div> | ||
</div> | ||
</div> | ||
<div class="c-tli__graphic"> | ||
<svg viewBox="0 0 100 100"> | ||
<g aria-label="Activity in progress" class="c-tli__graphic__pie"> | ||
<circle class="c-svg-progress__bg" r="50" cx="50" cy="50"></circle> | ||
<path ref="progressElement" class="c-svg-progress__progress"></path> | ||
<circle | ||
class="c-svg-progress__ticks" | ||
r="40" | ||
cx="50" | ||
cy="50" | ||
stroke-dasharray="3 7.472" | ||
></circle> | ||
<rect class="c-svg-progress__sweep-hand" x="48" y="18" width="4" height="27"></rect> | ||
</g> | ||
<path | ||
aria-label="Activity complete" | ||
class="c-tli__graphic__check" | ||
d="M80 20L42.5 57.5L20 35V57.5L42.5 80L80 42.5V20Z" | ||
/> | ||
<path | ||
aria-label="Activity alert" | ||
class="c-tli__graphic__alert-triangle" | ||
d="M79.4533 70.3034L54.004 25.7641C51.8962 22.0786 48.4636 22.0786 46.3559 25.7641L20.8946 70.3034C18.7868 73.989 20.5332 77 24.7728 77H75.563C79.8146 77 81.561 73.989 79.4533 70.3034ZM54.028 73.1459H46.3198V65.4376H54.028V73.1459ZM55.3409 50.0211L53.0645 61.5835H47.2833L45.007 50.0211V34.6045H55.3529V50.0211H55.3409Z" | ||
/> | ||
<g aria-label="Activity aborted" class="c-tli__graphic__circle-slash"> | ||
<path | ||
fill-rule="evenodd" | ||
clip-rule="evenodd" | ||
d="M50 82C67.6731 82 82 67.6731 82 50C82 32.3269 67.6731 18 50 18C32.3269 18 18 32.3269 18 50C18 67.6731 32.3269 82 50 82ZM50 72C62.1503 72 72 62.1503 72 50C72 37.8497 62.1503 28 50 28C37.8497 28 28 37.8497 28 50C28 62.1503 37.8497 72 50 72Z" | ||
/> | ||
<path | ||
d="M63.7886 29.6404L70.8596 36.7114L36.2114 71.3596L29.1404 64.2886L63.7886 29.6404Z" | ||
/> | ||
</g> | ||
<path | ||
aria-label="Activity skipped" | ||
class="c-tli__graphic__skipped" | ||
d="M31 48C31 42.4772 35.5152 38 41 38H59C64.4848 38 69 42.4772 69 48V55H58L74 72L90 55H79V48C79 36.9543 69.9695 28 59 28H41C30.0305 28 21 36.9543 21 48V53.0294C21 56.8792 17.8232 60 14 60V70C23.308 70 31 62.402 31 53.0294V48Z" | ||
/> | ||
</svg> | ||
</div> | ||
<div class="c-tli__time-hero"> | ||
<div class="c-tli__time-hero-context-and-time"> | ||
<div class="c-tli__time-hero-context">{{ formattedItemLabel }}</div> | ||
<div v-if="showTimeHero" :class="countdownClass"> | ||
{{ formattedItem.countdown }} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
<script> | ||
import _ from 'lodash'; | ||
|
||
import { TIME_CONTEXT_EVENTS } from '../../api/time/constants.js'; | ||
import { CURRENT_CSS_SUFFIX, FUTURE_CSS_SUFFIX, PAST_CSS_SUFFIX } from './constants.js'; | ||
import { updateProgress } from './inspector/svg-progress.js'; | ||
|
||
const ITEM_COLORS = { | ||
[CURRENT_CSS_SUFFIX]: '#ffcc00', | ||
[PAST_CSS_SUFFIX]: '#0088ff', | ||
[FUTURE_CSS_SUFFIX]: '#7300ff' | ||
}; | ||
|
||
const EXECUTION_STATES = { | ||
notStarted: 'Not started', | ||
'in-progress': 'In progress', | ||
completed: 'Completed', | ||
aborted: 'Aborted', | ||
skipped: 'Skipped' | ||
}; | ||
|
||
const INFERRED_EXECUTION_STATES = { | ||
incomplete: 'Incomplete', | ||
overdue: 'Overdue', | ||
runningLong: 'Running Long', | ||
starts: 'Starts', | ||
occurs: 'Occurs', | ||
occurred: 'Occurred', | ||
ends: 'Ends', | ||
ended: 'Ended' | ||
}; | ||
|
||
export default { | ||
inject: ['openmct', 'domainObject', 'path'], | ||
props: { | ||
item: { | ||
type: Object, | ||
required: true | ||
}, | ||
shefalijoshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
itemProperties: { | ||
type: Array, | ||
required: true | ||
}, | ||
executionState: { | ||
type: String, | ||
default() { | ||
return ''; | ||
} | ||
} | ||
}, | ||
data() { | ||
return { | ||
timestamp: this.openmct.time.now() | ||
shefalijoshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}; | ||
}, | ||
computed: { | ||
countdownClass() { | ||
let cssClass = ''; | ||
if (this.item.countdown < 0) { | ||
cssClass = '--is-countup'; | ||
} else if (this.item.countdown > 0) { | ||
cssClass = '--is-countdown'; | ||
} | ||
return `c-tli__time-hero-time ${cssClass}`; | ||
}, | ||
styleClass() { | ||
return { backgroundColor: ITEM_COLORS[this.item.cssClass] }; | ||
}, | ||
isInProgress() { | ||
return this.executionState === 'in-progress'; | ||
}, | ||
eventHasDuration() { | ||
return this.item.start !== this.item.end; | ||
}, | ||
listItemClass() { | ||
const timeRelationClass = this.item.cssClass; | ||
const executionStateClass = `--is-${this.executionState}`; | ||
return `c-tli ${timeRelationClass} ${executionStateClass}`; | ||
}, | ||
formattedItemLabel() { | ||
let executionStateLabel; | ||
const executionStateKeys = Object.keys(EXECUTION_STATES); | ||
const executionStateIndex = executionStateKeys.findIndex( | ||
(key) => key === this.executionState | ||
); | ||
if (executionStateIndex > -1) { | ||
executionStateLabel = EXECUTION_STATES[executionStateIndex]; | ||
} | ||
let label; | ||
// Start time is in the past | ||
if (this.item.start < this.timestamp) { | ||
if (this.item.start === this.item.end) { | ||
// - 'Occurred' : for Events with start < now datetime and 0 duration | ||
label = INFERRED_EXECUTION_STATES.occurred; | ||
} | ||
// end time has not yet passed | ||
else if (this.item.cssClass === CURRENT_CSS_SUFFIX) { | ||
if (executionStateIndex === 0) { | ||
// - 'Overdue' : executionState.notStarted && start < now datetime | ||
label = INFERRED_EXECUTION_STATES.overdue; | ||
} else if (executionStateIndex === 1) { | ||
// - 'Ends' : executionState.inProgress && now > start datetime && now < end datetime | ||
label = INFERRED_EXECUTION_STATES.ends; | ||
} | ||
} | ||
// end time is also in the past | ||
else if (this.item.cssClass === PAST_CSS_SUFFIX) { | ||
if (executionStateIndex === 0) { | ||
// - 'Incomplete' : executionState.notStarted && now > end datetime | ||
label = INFERRED_EXECUTION_STATES.incomplete; | ||
} else if (executionStateIndex === 1) { | ||
// - 'Running Long' : executionState.inProgress && now > end datetime | ||
label = INFERRED_EXECUTION_STATES.runningLong; | ||
} else if (executionStateIndex === -1) { | ||
// - 'Ended' :now > start datetime && now > end datetime | ||
label = INFERRED_EXECUTION_STATES.ended; | ||
} | ||
} | ||
} | ||
// Start time is in the future | ||
else { | ||
if (this.item.start === this.item.end) { | ||
// - 'Occurs' : for Events with start > now datetime and 0 duration | ||
label = INFERRED_EXECUTION_STATES.occurs; | ||
} else { | ||
// - 'Starts' : for Activities with now > start datetime | ||
label = INFERRED_EXECUTION_STATES.starts; | ||
} | ||
} | ||
|
||
return label || executionStateLabel; | ||
}, | ||
formattedItem() { | ||
let itemValue = { | ||
title: this.item.name | ||
}; | ||
this.itemProperties.forEach((itemProperty) => { | ||
let value = this.item[itemProperty.key]; | ||
let formattedValue; | ||
if (itemProperty.format) { | ||
const itemStartDate = new Date(value).toDateString(); | ||
const timestampDate = new Date(this.timestamp).toDateString(); | ||
formattedValue = itemProperty.format(value, this.item, itemProperty.key, this.openmct, { | ||
skipPrefix: true, | ||
skipDateForToday: itemStartDate === timestampDate | ||
}); | ||
} | ||
itemValue[itemProperty.key] = formattedValue; | ||
}); | ||
|
||
return itemValue; | ||
}, | ||
showTimeHero() { | ||
return !( | ||
this.executionState === EXECUTION_STATES.completed || | ||
this.executionState === EXECUTION_STATES.aborted || | ||
this.executionState === EXECUTION_STATES.skipped | ||
); | ||
} | ||
}, | ||
mounted() { | ||
this.updateTimestamp = _.throttle(this.updateTimestamp, 1000); | ||
this.setTimeContext(); | ||
this.timestamp = this.timeContext.now(); | ||
shefalijoshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
methods: { | ||
setTimeContext() { | ||
this.stopFollowingTimeContext(); | ||
this.timeContext = this.openmct.time.getContextForView(this.path); | ||
this.followTimeContext(); | ||
}, | ||
followTimeContext() { | ||
this.timeContext.on(TIME_CONTEXT_EVENTS.tick, this.updateTimestamp); | ||
}, | ||
stopFollowingTimeContext() { | ||
if (this.timeContext) { | ||
this.timeContext.off(TIME_CONTEXT_EVENTS.tick, this.updateTimestamp); | ||
} | ||
}, | ||
Comment on lines
+208
to
+220
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TimeContext stuff is gonna be a great candidate for a Open MCT specific Composable :D |
||
updateTimestamp(time) { | ||
this.timestamp = time; | ||
const progressElement = this.$refs.progressElement; | ||
if (this.isInProgress && progressElement) { | ||
updateProgress(this.item.start, this.item.end, this.timestamp, progressElement); | ||
} | ||
} | ||
} | ||
}; | ||
</script> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoa