Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 270 provide numerical output where zero means no differences found #278

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 13, 2024

GitHub Issue: #270

Description

This change makes it so there is a return value from the ncompare.compare function. The return value represents the total number of differences found (across variables, groups, and attributes). This enables for ncompare.compare to be used as a quick check, with ncompare.compare(file_1, file_2) == 0 representing no structural differences discovered between two netCDF files.

Local test steps

All tests passed.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--278.org.readthedocs.build/en/278/

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (6ebaafa) to head (302c7be).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
+ Coverage    92.18%   92.30%   +0.12%     
===========================================
  Files            5        6       +1     
  Lines          435      442       +7     
===========================================
+ Hits           401      408       +7     
  Misses          34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth added the enhancement New feature or request label Dec 13, 2024
@danielfromearth danielfromearth self-assigned this Dec 13, 2024
@danielfromearth danielfromearth merged commit e4ecd62 into develop Dec 13, 2024
9 checks passed
@danielfromearth danielfromearth deleted the feature/issue-270-provide-numerical-output-where-zero-means-no-differences-found branch December 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide numerical output - where zero means no differences found
1 participant