Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 275 add dimension names to report summary in addition to variable shape #277

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 12, 2024

GitHub Issue: #275

Description

Include dimensions in variable attribute comparisons.

Local test steps

Passed tests.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • [n/a] Documentation updated (if needed).

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.18%. Comparing base (575d128) to head (8244a49).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
ncompare/core.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
+ Coverage    91.62%   92.18%   +0.55%     
===========================================
  Files            5        5              
  Lines          442      435       -7     
===========================================
- Hits           405      401       -4     
+ Misses          37       34       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth merged commit 8981a56 into develop Dec 12, 2024
11 checks passed
@danielfromearth danielfromearth deleted the feature/issue-275-add-dimension-names-to-report-summary-in-addition-to-variable-shape branch December 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dimension names to report summary, in addition to variable shape
1 participant