Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 271 - Remove randomized value check #272

Merged

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 11, 2024

GitHub Issue: #271

Description

This removes the functionality of comparing randomly selected values from a chosen group/variable. This was not used in most cases, and added to package maintenance burden.

Local test steps

Passed unit tests.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--272.org.readthedocs.build/en/272/

@danielfromearth danielfromearth changed the title Feature/issue 271 remove randomized value check Feature/issue 271 - Remove randomized value check Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (86a155d) to head (0213966).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
+ Coverage    90.61%   91.50%   +0.88%     
===========================================
  Files            5        5              
  Lines          469      400      -69     
===========================================
- Hits           425      366      -59     
+ Misses          44       34      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth added the enhancement New feature or request label Dec 11, 2024
@danielfromearth danielfromearth linked an issue Dec 11, 2024 that may be closed by this pull request
@danielfromearth danielfromearth self-assigned this Dec 11, 2024
@danielfromearth danielfromearth merged commit 3e39e61 into develop Dec 11, 2024
11 checks passed
@danielfromearth danielfromearth deleted the feature/issue-271-remove-randomized-value-check branch December 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove randomized value check
1 participant