Skip to content

MMT-3998: As a user, I can edit the Specification for umm-viz 'tiles' records #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2025

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented May 30, 2025

Overview

What is the feature?

As a user, I can edit the Specification for umm-viz 'tiles' records

What is the Solution?

Adding Specification form to vis drafts

What areas of the application does this impact?

vis forms, and a few widgets/fields needed updating to accommodate schema

Testing

Reproduction steps

  • **Environment for testing: any
  • **Collection to test with: any
  1. Create a new draft and test all fields within Specification. Make sure they show up in the JSON as expected and do not produce any new errors. The "Warning: validateDOMNesting(...): cannot appear as a descendant of . Error Component Stack" is a known error not related to this ticket.

Attachments

N/A

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (fa8f53c) to head (7ee7b19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         399      401    +2     
  Lines        6536     6553   +17     
  Branches     1367     1356   -11     
=======================================
+ Hits         6397     6414   +17     
  Misses        138      138           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eudoroolivares2016 eudoroolivares2016 changed the title Mmt 3998: As a user, I can edit the Specification for umm-viz 'tiles' records MMT-3998: As a user, I can edit the Specification for umm-viz 'tiles' records May 31, 2025
@mandyparson mandyparson merged commit 359ab35 into main Jun 5, 2025
7 checks passed
@mandyparson mandyparson deleted the MMT-3998 branch June 5, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants