Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MMT-3962: Added console log statements to help debug issue with login. (#1336)" #1337

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

cgokey
Copy link
Collaborator

@cgokey cgokey commented Jan 23, 2025

Overview

What is the feature?

This PR just reverts my previous commits of console log statements to help debug why users couldn't login.

What is the Solution?

Used git revert to revert the last commit

What areas of the application does this impact?

SAML callback handler.

Testing

Basic regression testing.

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (7d10ed7) to head (c602cf9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files         365      365              
  Lines        5773     5762      -11     
  Branches     1214     1214              
==========================================
- Hits         5640     5629      -11     
  Misses        132      132              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgokey cgokey merged commit c190bc5 into main Jan 30, 2025
7 checks passed
@cgokey cgokey deleted the MMT-3962 branch January 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants