Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmt 3946b: Reverting changes from MMT-3946 #1328

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Mmt 3946b: Reverting changes from MMT-3946 #1328

merged 2 commits into from
Dec 4, 2024

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

The fix of using userId to determine if a record has been deleted was too narrow to be plausibly usable. However, this decision was made after MMT-3946 had been merged to main. New ticket to remove old code.

What is the Solution?

Put things back to the way they were with the exception of descriptionCellContent and ActionCellContent, destructed for clarity and also preserved the if, else statements as we will eventually use them when logic for deleted rows comes into play.

What areas of the application does this impact?

RevisionList

Testing

Reproduction steps

  • **Environment for testing: UAT
  • **Collection to test with: V1256589611-MMT_2
  1. Go to that variable above and click 'revisions'
  2. All revision rows should look the same even though revision row with userId 'cmr' has been deleted.

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mandyparson mandyparson requested review from cgokey and htranho December 3, 2024 21:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (53c2a92) to head (ee721af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   97.68%   97.68%   -0.01%     
==========================================
  Files         366      366              
  Lines        5757     5751       -6     
  Branches     1199     1207       +8     
==========================================
- Hits         5624     5618       -6     
  Misses        132      132              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson mandyparson merged commit 30375f8 into main Dec 4, 2024
5 of 7 checks passed
@mandyparson mandyparson deleted the MMT-3946b branch December 4, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants