-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmt 3936: URS Login/Token Refresh Results in Blank Page #1327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
- Coverage 97.68% 97.68% -0.01%
==========================================
Files 366 365 -1
Lines 5757 5750 -7
Branches 1199 1208 +9
==========================================
- Hits 5624 5617 -7
Misses 132 132
Partials 1 1 ☔ View full report in Codecov by Sentry. |
static/src/js/components/TemplateList/__tests__/TemplateList.test.jsx
Outdated
Show resolved
Hide resolved
static/src/js/providers/AuthContextProvider/AuthContextProvider.jsx
Outdated
Show resolved
Hide resolved
static/src/js/providers/AuthContextProvider/__tests__/AuthContextProvider.test.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. We should just not use relative paths in imports, so these should be changed back to absolute paths.
@@ -9,7 +9,7 @@ import errorLogger from '@/js/utils/errorLogger' | |||
import getTemplates from '@/js/utils/getTemplates' | |||
import deleteTemplate from '@/js/utils/deleteTemplate' | |||
import NotificationsContext from '@/js/context/NotificationsContext' | |||
import MMT_COOKIE from '@/js/constants/mmtCookie' | |||
import MMT_COOKIE from 'sharedConstants/mmtCookie' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does @/sharedConstants/mmtCookie
not work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. That's only for files within static/src. I had to create a new route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable was needed for files within serverless/src as well and Matthew said that we need to keep the static/src and serverless/src separate (no shared constantsor utils). To solve this, I needed to cretae a new folder called sharedConstants which is similar to sharedUtils.
Overview
What is the feature?
This ticket does not have reproduction steps and the only thing that I was able to find upon inspect is that this behavior occurs when switching between SIT and either UAT or PROD. Needed a way to keep the page from hanging when a user toggles between the two
What is the Solution?
It did appear to be an issue with cookies. Added the environment to the MMT_COOKIE label to overcome
What areas of the application does this impact?
List impacted areas.
Anywhere that used MMT_COOKIE
Reproduction steps
2.Now do the same when switched onto my branch. You'll notice that when you delete cookies on one side, the other does not automatically load up again.
Attachments
None.
Checklist