Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3908: Adding pagination to ACL #1304

Merged
merged 1 commit into from
Sep 27, 2024
Merged

MMT-3908: Adding pagination to ACL #1304

merged 1 commit into from
Sep 27, 2024

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Sep 26, 2024

Overview

What is the feature?

Needed to add pagination to /permssions/conceptId and the collection table

What is the Solution?

Added pagination

What areas of the application does this impact?

PermissionCollectionTable.jsx

Testing

Reproduction steps

  • **Environment for testing: Any
  • Collection to test with:
  1. Select an ACL and check pagiantion for three use cases: all collections permitted, less than 20 collections permitted, more than 20 collections permitted.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (e7e5afa) to head (b08a0f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   97.65%   97.66%           
=======================================
  Files         362      362           
  Lines        5584     5601   +17     
  Branches     1172     1177    +5     
=======================================
+ Hits         5453     5470   +17     
  Misses        130      130           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson mandyparson merged commit 86b5bf0 into main Sep 27, 2024
5 checks passed
@mandyparson mandyparson deleted the MMT-3908 branch September 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants