Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmt 3902: As a user, I would like to paginate through my collection associations #1300

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

Users could not paginate through Collection Association Results

What is the Solution?

Adding Pagination

What areas of the application does this impact?

ManageCollectionAssociation.jsx

Testing

Reproduction steps

  • **Environment for testing: Find a Service with more than 20 Associations or do the associations yourself. The one I'm using in UAT is here: /services/S1226158232-MMT_1/collection-association
  • Collection to test with:
  1. Select a service >> go to Collection Associations >> check that you can paginate through associations

Attachments

Screenshot 2024-09-20 at 9 46 38 AM

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mandyparson mandyparson changed the base branch from master to main September 20, 2024 15:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.51%. Comparing base (81eff52) to head (f96e272).

Files with missing lines Patch % Lines
...lectionAssociation/ManageCollectionAssociation.jsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   97.52%   97.51%   -0.01%     
==========================================
  Files         362      362              
  Lines        5540     5559      +19     
  Branches     1155     1167      +12     
==========================================
+ Hits         5403     5421      +18     
- Misses        136      137       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -137,13 +141,297 @@ export const toolRecordSearch = {
}
}
}
export const toolRecordSearchwithPages = {
request: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having these long mocks in its own file, I think future PRs, I may start pulling them out.

@mandyparson mandyparson merged commit b2f7188 into main Sep 24, 2024
5 checks passed
@mandyparson mandyparson deleted the MMT-3902 branch September 24, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants