MMT-3418: As a metadata user, I want to CRUD draft UMM-V records #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: CustomSelect CustomTextarea CustomDateTime CustomArrayField
mandyparson
reviewed
Jan 5, 2024
trevorlang
approved these changes
Jan 5, 2024
static/src/js/components/CustomSelectWidget/CustomSelectWidget.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/CustomSelectWidget/CustomSelectWidget.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/CustomSelectWidget/CustomSelectWidget.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/GridCheckboxPanel/GridCheckboxPanel.jsx
Outdated
Show resolved
Hide resolved
static/src/js/components/GridCheckboxPanel/GridCheckboxPanel.jsx
Outdated
Show resolved
Hide resolved
trevorlang
requested changes
Jan 5, 2024
dmistry1
commented
Jan 8, 2024
tle1989
approved these changes
Jan 12, 2024
cgokey
reviewed
Jan 17, 2024
static/src/js/components/GridGroupedSinglePanel/GridGroupedSinglePanel.jsx
Outdated
Show resolved
Hide resolved
cgokey
reviewed
Jan 17, 2024
static/src/js/components/GridGroupedSinglePanel/__tests__/GridGroupedSinglePanel.test.js
Outdated
Show resolved
Hide resolved
cgokey
reviewed
Jan 17, 2024
static/src/js/components/GridGroupedSinglePanel/__tests__/GridGroupedSinglePanel.test.js
Outdated
Show resolved
Hide resolved
cgokey
reviewed
Jan 17, 2024
cgokey
approved these changes
Jan 25, 2024
htranho
approved these changes
Jan 25, 2024
trevorlang
approved these changes
Jan 26, 2024
| const formArrays = Object.values(formDataParam) | ||
|
|
||
| // eslint-disable-next-line max-len | ||
| return formArrays.every((formArray) => formArray.filter(isNullOrUndefined).length === formArray.length) |
There was a problem hiding this comment.
This can be reformatted to prevent the max-len error
| Object.getOwnPropertyNames(formData).map((field) => ( | ||
| // eslint-disable-next-line no-param-reassign | ||
| delete formData[field] | ||
| // } |
| } | ||
|
|
||
| // eslint-disable-next-line no-param-reassign | ||
| formData = {} |
There was a problem hiding this comment.
I think its generally bad to be manipulating the keys of an object, which is why eslint is complaining. Did you try to achieve this without having to manipulate the object like this?
| if (!found) { | ||
| return null | ||
| } | ||
| // Const { oneOf } = schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.