Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pre-commit hooks. #2

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Conversation

owenlittlejohns
Copy link
Member

Description

This is analogous to the HOSS PR adding pre-commit hooks to this project. It adds:

  • Trailing whitespace
  • Blank lines at the end of the file.
  • Valid JSON and YAML syntax.
  • ruff linting.
  • black code formatting.

Note, these should only run on files that are touched in a commit.

Jira Issue ID

N/A - IP-sprint activity.

Local Test Steps

  • Pull this branch.
  • Follow the new instructions in the README, including the optional pre-commit run --all-files.
  • To really test this, make some minor change, use git add then git commit. You should see the checks all run when you are trying to use git commit.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

get_ewa_information,
get_ewa_results,
get_near_information,
get_near_results,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other PR, I ran everything but black over --all-files. These are things that ruff picked up for us.

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@owenlittlejohns owenlittlejohns merged commit 7fbe1f6 into main Apr 6, 2024
3 checks passed
@owenlittlejohns owenlittlejohns deleted the implement-pre-commit branch April 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants