-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-558 - Migrate to earthdata-varinfo==3.0.0. #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two typos to fix. But looks good to me.
CHANGELOG.md
Outdated
## [v1.1.1] - 2024-09-16 | ||
### Changed | ||
|
||
- [[TRT-558]](https://bugs.earthdata.nasa.gov/browse/TRT-558)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [[TRT-558]](https://bugs.earthdata.nasa.gov/browse/TRT-558)] | |
- [[TRT-558](https://bugs.earthdata.nasa.gov/browse/TRT-558)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that: 2cd831.
"_Description": "VNP10 SnowData variables have incorrect relative paths for coordinates." | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got tabbified somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh - weird. I thought my editor was set up to automatically convert tabs to spaces. Ah well, I updated that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for the updates
Description
This PR updates the Swath Projector to use
earthdata-varinfo==3.0.0
. This version of theearthdata-varinfo
package includes significant updates to the configuration file schema and some of the publicly accessible methods and attributes on classes contained in the package.In this service, it looks like that none of the updated class attributes and methods were being called, so the only updates were to the configuration file itself (mainly removing a couple of underscores and renaming
CF_Overrides
toMetadataOverrides
). I've also renamed that configuration file for clarity.Jira Issue ID
TRT-558.
Local Test Steps
CHANGELOG.md
to make sure I got the updated format right../bin/buid-image && ./bin/build-test && ./bin/run-test
.earthdata-varinfo
schema (will require thejsonschema
Python package):PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.