Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1933: Add harmony environment name to the harmony-regression-tests action name and notification. #109

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Oct 29, 2024

Description

Add harmony environment name to the harmony-regression-tests action name and notification. Below is the difference of the Action Name change between main and the PR branch.
Screenshot 2024-10-29 at 4 06 03 PM

Email notification has similar changes.

Jira Issue ID

HARMONY-1933

Local Test Steps

Run Jupyter notebook based test suite manually to see the Action name and email notification changes, and they are more informative with the Harmony environment in them.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • CHANGELOG updated with the changes for this PR

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ygliuvt ygliuvt merged commit e32aa94 into main Oct 30, 2024
4 checks passed
@ygliuvt ygliuvt deleted the harmony-1933 branch October 30, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants