Skip to content

Commit

Permalink
Update reference files for DAS-2205 bug fix (#103)
Browse files Browse the repository at this point in the history
* Update reference files for DAS-2205 bug fix, add try/except to compare function to all tests to run.

* Update CHANGELOG.md.

* Run pre-commit and remove trailing whitespace.

* DAS-2205 - Move try/except to tests, print test result report, and throw an error if a test fails.

* DAS-2205 - Update nsidc-icesat2 image version.

* Remove empty cell.

* Remove full run of notebook with fails for efficiency.

* Re-add accidentally removed print_success.

* Correct typo.

* Correct typo.
  • Loading branch information
lyonthefrog authored Oct 11, 2024
1 parent d0a7e18 commit 45ba2f4
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 9 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,21 @@ versioning. Rather than a static releases, this repository contains of a number
of regression tests that are each semi-independent. This CHANGELOG file should be used
to document pull requests to this repository.

## 2024-10-11 ([#103](https://github.com/nasa/harmony-regression-tests/pull/103))

- Update the ATL03 and ATL08 reference files in the `nsidc-icesat2` regression
test notebook to adjust to the DAS-2205 bug fix.
- Updates the `shared_utils` function `compare_results_to_reference_file_new`
to surround comparison assertion with a `try`/`except` so all tests are run
even when a comparison fails.

## 2024-10-02 ([#99](https://github.com/nasa/harmony-regression-tests/pull/99))

- Adds NSIDC ICESat2 Production Regression configuration.
- Updates the `shared_utils` function `compare_results_to_reference_file_new`
to take a new optional argument `identical` which defaults to `True` but if
set to `False` the Datatree comparison falls back to an `equals` test
ignoring metadata in its reference file comparions.
ignoring metadata in its reference file comparisons.


## 2024-09-24 ([#92](https://github.com/nasa/harmony-regression-tests/pull/92))
Expand Down
2 changes: 1 addition & 1 deletion test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.5"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
2 changes: 1 addition & 1 deletion test/nsidc-icesat2/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.3
0.0.4

0 comments on commit 45ba2f4

Please sign in to comment.