-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3719, EDSC-3525: Scroll to granule on map click and table granules bugfix #1813
Conversation
… of parsing the location.
…rds from GranuleResultsItem.
… where table view was not highlighting the granule when clicked on the map. Added playwright tests to test all of this new functionality.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 91.02% 90.98% -0.05%
==========================================
Files 770 770
Lines 18567 18584 +17
Branches 4778 4797 +19
==========================================
+ Hits 16901 16909 +8
- Misses 1525 1533 +8
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few files without new lines at the end but other than that, this is looking really solid. Nice work!
tests/e2e/paths/search/granules/__mocks__/cmr_granules/collections.body.json
Outdated
Show resolved
Hide resolved
tests/e2e/paths/search/granules/__mocks__/cmr_granules/granules.body.json
Outdated
Show resolved
Hide resolved
…nent usage of EDSCTable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking this PR for now because we have to get 4252 in first
Overview
What is the feature?
When clicking on a granule on the map, the granule list and granule table will scroll to that granule. Additionally fixed a bug where granules on the granules table weren't highlighting the focused granule.
What is the Solution?
Updated EDSCTable to highlight granules in table view
Added scrolling when there is a focusedGranule in GranuleResultsListBody.jsx & EDSCTable
Added playwright tests to check functionality.
What areas of the application does this impact?
Granules Table and List views.
Testing
Reproduction steps
6.observe the table scrolling
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist