Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3719, EDSC-3525: Scroll to granule on map click and table granules bugfix #1813

Merged
merged 36 commits into from
Oct 31, 2024

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Oct 23, 2024

Overview

What is the feature?

When clicking on a granule on the map, the granule list and granule table will scroll to that granule. Additionally fixed a bug where granules on the granules table weren't highlighting the focused granule.

What is the Solution?

Updated EDSCTable to highlight granules in table view
Added scrolling when there is a focusedGranule in GranuleResultsListBody.jsx & EDSCTable
Added playwright tests to check functionality.

What areas of the application does this impact?

Granules Table and List views.

Testing

Reproduction steps

  1. goto localhost:8080/search
  2. click on a collection with a bunch of granules
  3. select a granule on the map and observe that the list scrolls to it and that it is highlighted.
  4. change to the table view and observe that the table scrolls to the focusedGranule
  5. de-select a granule and select a different one that is far enough so that it forces the table to scroll.
    6.observe the table scrolling
  6. move back to the list view and observe the list view scrolls to that same granule

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

… where table view was not highlighting the granule when clicked on the map. Added playwright tests to test all of this new functionality.
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (d918cd6) to head (522ab9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/GranuleResults/GranuleResultsListBody.jsx 50.00% 5 Missing and 1 partial ⚠️
static/src/js/components/EDSCTable/EDSCTable.jsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
- Coverage   91.02%   90.98%   -0.05%     
==========================================
  Files         770      770              
  Lines       18567    18584      +17     
  Branches     4778     4797      +19     
==========================================
+ Hits        16901    16909       +8     
- Misses       1525     1533       +8     
- Partials      141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@trevorlang trevorlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few files without new lines at the end but other than that, this is looking really solid. Nice work!

@bnp26 bnp26 requested a review from macrouch October 29, 2024 16:58
Copy link
Contributor

@macrouch macrouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking this PR for now because we have to get 4252 in first

@bnp26 bnp26 requested a review from macrouch October 30, 2024 21:00
@bnp26 bnp26 merged commit b0df37e into main Oct 31, 2024
11 checks passed
@bnp26 bnp26 deleted the EDSC-3719 branch October 31, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants