Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4162: Create a Guided Tour For Users of Earthdata Search #1800

Merged
merged 81 commits into from
Oct 20, 2024
Merged

Conversation

dpesall
Copy link
Member

@dpesall dpesall commented Sep 10, 2024

Overview

What is the feature?

Creating a guided tour for EDSC users

What is the Solution?

Creating a tour using React-Joyride

What areas of the application does this impact?

EDSC Search Endpoint

Testing

Reproduction steps

  1. Click "Start Tour" on the toolbar
  2. Verify that all the steps work and the links function

Attachments

Screenshot 2024-10-16 at 4 46 56 PM
Screenshot 2024-10-16 at 4 47 01 PM
Screenshot 2024-10-16 at 4 47 11 PM
Screenshot 2024-10-16 at 4 47 16 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (64d56ce) to head (65c7932).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   93.40%   93.46%   +0.06%     
==========================================
  Files         766      772       +6     
  Lines       18457    18555      +98     
  Branches     4759     4755       -4     
==========================================
+ Hits        17239    17342     +103     
- Misses       1134     1165      +31     
+ Partials       84       48      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@macrouch macrouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a Playwright test would make sense to ensure each step works as intended, and we don't break it in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

732 Lines is a huge component. To make it easier for devs to parse you could split out components into their own files (that would also make testing each component easier). You could also look at moving the steps into their own file, that seems like the vast majority of the actual lines.

@dpesall dpesall merged commit 33de064 into main Oct 20, 2024
11 checks passed
@dpesall dpesall deleted the EDSC-4162-2 branch October 20, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants