-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4162: Create a Guided Tour For Users of Earthdata Search #1800
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
+ Coverage 93.40% 93.46% +0.06%
==========================================
Files 766 772 +6
Lines 18457 18555 +98
Branches 4759 4755 -4
==========================================
+ Hits 17239 17342 +103
- Misses 1134 1165 +31
+ Partials 84 48 -36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a Playwright test would make sense to ensure each step works as intended, and we don't break it in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
732 Lines is a huge component. To make it easier for devs to parse you could split out components into their own files (that would also make testing each component easier). You could also look at moving the steps
into their own file, that seems like the vast majority of the actual lines.
Overview
What is the feature?
Creating a guided tour for EDSC users
What is the Solution?
Creating a tour using React-Joyride
What areas of the application does this impact?
EDSC Search Endpoint
Testing
Reproduction steps
Attachments
Checklist