EDSC-3773: Some adjustments to the EDSC-3773 merge

[bnp26]

Overview

What is the feature?

Some additional simplification and adjustments to the EDSC-3773 ticket

What is the Solution?

• Moved out all the logic bocks in buildAccessMethods into their one files (1 for each logic block).
• Created tests for each of those logic blocks and updated the buildAccessMethods to test that those methods get called the correct number of times and with the correct params.

What areas of the application does this impact?

List impacted areas.

Testing

Reproduction steps

• Environment for testing: localhost
• Collection to test with: N/A

1. go to Test Collections and pick out 1 collection for each accessMethod type.
   EX:
   oPeNDAP: C1453188197-GES_DISC
   Harmony: C1595422627-ASF
   Echo Order: C179031504-LARC
   Echo Order: C1200382306-CMR_ONLY (In SIT, testing new feature allowing for multiple Echo Order/ESI services to show up to be downloaded)
   ESI: (The first good collection I found was in SIT C1200427107-EDF_DEV06)
   Download: (any of the top 4)
2. navigate to locahost:8080/search?ee=prod
3. for each collection, add some granules and click download
4. Observe the downloads work correctly.

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (64476b5) to head (06c41db).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
+ Coverage   93.17%   93.33%   +0.16%     
==========================================
  Files         755      757       +2     
  Lines       18245    18272      +27     
  Branches     4686     4709      +23     
==========================================
+ Hits        17000    17055      +55     
+ Misses       1197     1132      -65     
- Partials       48       85      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trevorlang]

This is looking solid. As long as you tested out a collection that has no services assigned, I am good with this 👍