EDSC-4055: Add performance based testing to our code base to assist prevent regression #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
===========================================
- Coverage 92.19% 82.19% -10.01%
===========================================
Files 747 696 -51
Lines 19901 17434 -2467
Branches 4763 4575 -188
===========================================
- Hits 18348 14330 -4018
- Misses 1408 2890 +1482
- Partials 145 214 +69 ☔ View full report in Codecov by Sentry. |
dpesall
approved these changes
Jun 12, 2024
eudoroolivares2016
approved these changes
Jun 12, 2024
eudoroolivares2016
previously requested changes
Jun 12, 2024
dpesall
reviewed
Jun 12, 2024
rushgeo
approved these changes
Jul 17, 2024
eudoroolivares2016
approved these changes
Jul 17, 2024
* EDSC-3937: Implement Vite EDSC-3937 removes workflow dispatch EDSC-3937: Updates portal configs to pre compile list of availablePortals EDSC-3937: Fixes pg EDSC-3937: Fixes serverless env EDSC-3937: Fix deployment EDSC-3937: Fixes more tests EDSC-3937: Fixes some tests EDSC-3937: Fixes datepicker test EDSC-3937: Fixes build output EDSC-3937: Updates Vite configs EDSC-3937 post rebase fixes EDSC-3937 ci test update workflow_dispatch EDSC-3937 playwright test configuration fixes EDSC-3937 jest config fixes EDSC-3937 leaflet fixes, package.json updates EDSC-3937 rename static src files to jsx EDSC-3937 package.json updates, import scss fixes EDSC-3937 restore App.js and index.js * EDSC-3937: Fixes leaflet issues, rename files * EDSC-3937: Fixes map tests * EDSC-3937 misc fixes * EDSC-3937 removes empty lines in SCSS files * EDSC-3937 removes uneeded code and files, addresses other pr comments * EDSC-3937 removes more files * EDSC-3937: Removes need for sass imports * EDSC-3937: Add Playwright coverage report to artifact for debugging * EDSC-3937: Fixes playwright code coverage * EDSC-3937 reverts collection_details test * EDSC-3937: Fixes playwright import to include coverage * EDSC-3937: Remove unused libraries * EDSC-3937: Fixes test * EDSC-3937: Fixes build * EDSC-3937: Fixes sharp in serverless --------- Co-authored-by: Matthew Crouch <[email protected]>
…into EDSC-4055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Adding some basic metrics for tracking in Playwright tests. LCP tracking and Time to Last Byte of the Search pages load time.
What is the Solution?
Added two playwright tests to capture the LCP and the response end time of the search page loading. This correlates to the time it takes to receive all javascript code.
What areas of the application does this impact?
No impact to the actual application.
Testing
Reproduction steps
Running the playwright tests will show allow for inspection of the metrics.
Attachments
Search page metrics
LCP passing test.
Checklist