Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3833: Improve Customizable facet messaging #1657

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Aug 7, 2023

Overview

What is the feature?

  • Added a '?' to the end of the customizable and made it so when hovered over it gives more detailed information as a tooltip on what selecting the checkbox will do.
  • Also updated the tests for Facets.js to use React Testing Framework instead of Enzyme.

What is the Solution?

Added a new prop to the FacetItem called description that when contains a string, the '?' icon will show up at the end of the checkbox with that description showing up on hover.

What areas of the application does this impact?

Just the Facets.js/FacetsItem.js.

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. go to /search.
  2. Navigate to the Customizable checkbox and hover over the '?' icon at the end of it.
  3. Ensure the popup shows up with the correct message.

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
image

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1657 (83efe95) into main (c8878b4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
+ Coverage   91.51%   91.56%   +0.04%     
==========================================
  Files         709      709              
  Lines       18970    18972       +2     
  Branches     4436     4438       +2     
==========================================
+ Hits        17361    17371      +10     
+ Misses       1471     1463       -8     
  Partials      138      138              
Files Changed Coverage Δ
static/src/js/components/Facets/Facets.js 100.00% <ø> (ø)
static/src/js/components/Facets/FacetsItem.js 90.47% <100.00%> (+15.47%) ⬆️

... and 3 files with indirect coverage changes

@macrouch macrouch merged commit 577dd02 into nasa:main Aug 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants