-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3665: Upgrade AWS SDK from v2 to v3 #1645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverless/src/util/database/__tests__/getDbCredentials.test.js
Outdated
Show resolved
Hide resolved
serverless/src/util/__tests__/startOrderStatusUpdateWorkflow.test.js
Outdated
Show resolved
Hide resolved
serverless/src/util/google/__tests__/getGoogleMapsApiKey.test.js
Outdated
Show resolved
Hide resolved
…als.test.js Co-authored-by: Ed Olivares <[email protected]>
…Workflow.test.js Co-authored-by: Ed Olivares <[email protected]>
Co-authored-by: Ed Olivares <[email protected]>
…iKey.test.js Co-authored-by: Ed Olivares <[email protected]>
Co-authored-by: Ed Olivares <[email protected]>
Co-authored-by: Ed Olivares <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.03%
==========================================
Files 702 702
Lines 18828 18830 +2
Branches 4400 4400
==========================================
- Hits 17246 17244 -2
- Misses 1446 1448 +2
- Partials 136 138 +2
|
eudoroolivares2016
approved these changes
Jun 22, 2023
serverless/src/generateColorMaps/__tests/getProjectionCapabilities.test.js
Show resolved
Hide resolved
jaybarra
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Upgrading AWS SDK from v2 to v3
What is the Solution?
In AWS SDK v3, services are modularized into individual service clients instead of one large AWS object.
What areas of the application does this impact?
Implementations of AWS services such as SQS, S3, DynamoDB, SecretsManager
Testing
Reproduction steps
npm run test
Checklist