Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3665: Upgrade AWS SDK from v2 to v3 #1645

Merged
merged 31 commits into from
Jun 26, 2023
Merged

EDSC-3665: Upgrade AWS SDK from v2 to v3 #1645

merged 31 commits into from
Jun 26, 2023

Conversation

dpesall
Copy link
Member

@dpesall dpesall commented Jun 21, 2023

Overview

What is the feature?

Upgrading AWS SDK from v2 to v3

What is the Solution?

In AWS SDK v3, services are modularized into individual service clients instead of one large AWS object.

What areas of the application does this impact?

Implementations of AWS services such as SQS, S3, DynamoDB, SecretsManager

Testing

Reproduction steps

  • Running the jest test suite locally
  1. Pull down this branch of Earthdata Search
  2. Run npm run test
  3. Verify all tests pass

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1645 (c7c36fd) into main (c54faf2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.03%     
==========================================
  Files         702      702              
  Lines       18828    18830       +2     
  Branches     4400     4400              
==========================================
- Hits        17246    17244       -2     
- Misses       1446     1448       +2     
- Partials      136      138       +2     
Impacted Files Coverage Δ
serverless/src/edlCallback/handler.js 100.00% <100.00%> (ø)
...ss/src/generateCollectionCapabilityTags/handler.js 96.87% <100.00%> (ø)
...src/generateColorMaps/getProjectionCapabilities.js 100.00% <100.00%> (ø)
serverless/src/generateGibsTags/handler.js 72.09% <100.00%> (ø)
serverless/src/requeueOrder/handler.js 100.00% <100.00%> (ø)
serverless/src/submitRetrieval/handler.js 87.03% <100.00%> (+0.24%) ⬆️
serverless/src/util/database/getDbCredentials.js 81.81% <100.00%> (ø)
serverless/src/util/getAdminUsers.js 81.81% <100.00%> (ø)
serverless/src/util/getEdlConfig.js 85.71% <100.00%> (-0.96%) ⬇️
serverless/src/util/google/getGoogleMapsApiKey.js 81.81% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@dpesall dpesall merged commit 99f92e9 into nasa:main Jun 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants