-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3762: As a user, I want to download the downloader app if it is not available on my machine #1643
Conversation
static/src/js/containers/EddLandingPageContainer/EarthdataDownloadContainer.js
Outdated
Show resolved
Hide resolved
static/src/js/components/TextWindowActions/__tests__/TextWindowActions.test.js
Outdated
Show resolved
Hide resolved
static/src/js/containers/EddLandingPageContainer/__tests__/EarthdataDownloadContainer.test.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 91.59% 91.52% -0.07%
==========================================
Files 702 705 +3
Lines 18830 18906 +76
Branches 4400 4417 +17
==========================================
+ Hits 17247 17304 +57
- Misses 1446 1466 +20
+ Partials 137 136 -1
|
static/src/js/components/EarthdataDownload/EarthdataDownload.scss
Outdated
Show resolved
Hide resolved
static/src/js/components/EarthdataDownload/EarthdataDownload.scss
Outdated
Show resolved
Hide resolved
static/src/js/components/EarthdataDownload/EarthdataDownload.scss
Outdated
Show resolved
Hide resolved
"Download for Linux", we should call out the .AppImage file, that is the only one that supports auto update once we get to that ticket. You should also provide links to all 3 linux files, .AppImage, .deb and .rpm |
static/src/js/components/EarthdataDownload/EarthdataDownload.js
Outdated
Show resolved
Hide resolved
To the point about the app logo on the modal Trevor had asked me to remove it entirely from the modal |
Added links to the alternative Linux downloads (.deb and .rpm) promoted .AppImage to the top level |
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there changes to package-lock.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did an npm audit fix
for the EDSC-3804
vulnerability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we already have a ticket to update libraries, they need to be updated in that ticket, not added on to a separate effort where we can't track that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted package-lock switch. Tracking separately
/** | ||
* Get the operating system of the client | ||
* @param {String} userAgent - A string containing the navigator.userAgent from browser | ||
* @return {String} The operating system from the client as a string being returned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing but I think this would be:
* @return {String} The operating system from the client as a string being returned | |
* @return {(String|Null}} The operating system from the client as a string being returned |
Overview
What is the feature?
Provide a way to download the EDD (Earthdata download) application for the first time. Provide the correct installation depending on the operating system the user has.
What is the Solution?
Adds a page to EDSC for more information and all download links to the Earthdata Download application. Adds a link to install EDD from the textWindowActions modal on the download files page
What areas of the application does this impact?
The TextWindow Actions. Creates a new route on EDSC
/earthdata-download
Testing
Download some metadata using the standard workflow. When we get to the download files button click on it and then click on the prompt to install Earthdata download. Also click on the 'learn more' link that will take the user to the EDD landing page on EDSC.
Reproduction steps
Find some collections or granules to download go through the download workflow. Hit the "Download Files" button under the Download Files tab. Then download the correct version of EDD for your OS. Hit the Learn more button to go to the landing page
Attachments
Checklist