Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3762: As a user, I want to download the downloader app if it is not available on my machine #1643

Merged
merged 32 commits into from
Jul 3, 2023

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Jun 19, 2023

Overview

What is the feature?

Provide a way to download the EDD (Earthdata download) application for the first time. Provide the correct installation depending on the operating system the user has.

What is the Solution?

Adds a page to EDSC for more information and all download links to the Earthdata Download application. Adds a link to install EDD from the textWindowActions modal on the download files page

What areas of the application does this impact?

The TextWindow Actions. Creates a new route on EDSC /earthdata-download

Testing

Download some metadata using the standard workflow. When we get to the download files button click on it and then click on the prompt to install Earthdata download. Also click on the 'learn more' link that will take the user to the EDD landing page on EDSC.

Reproduction steps

  • Environment for testing:
  • Collection to test with:

Find some collections or granules to download go through the download workflow. Hit the "Download Files" button under the Download Files tab. Then download the correct version of EDD for your OS. Hit the Learn more button to go to the landing page

Attachments

image

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1643 (f9dc7f6) into main (99f92e9) will decrease coverage by 0.07%.
The diff coverage is 72.36%.

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   91.59%   91.52%   -0.07%     
==========================================
  Files         702      705       +3     
  Lines       18830    18906      +76     
  Branches     4400     4417      +17     
==========================================
+ Hits        17247    17304      +57     
- Misses       1446     1466      +20     
+ Partials      137      136       -1     
Impacted Files Coverage Δ
static/src/js/App.js 64.86% <0.00%> (-3.71%) ⬇️
...c/js/routes/EarthdataDownload/EarthdataDownload.js 33.33% <33.33%> (ø)
.../components/EarthdataDownload/EarthdataDownload.js 66.66% <66.66%> (ø)
.../components/TextWindowActions/TextWindowActions.js 96.10% <84.21%> (-3.90%) ⬇️
static/src/js/components/Button/Button.js 100.00% <100.00%> (ø)
static/src/js/util/files/parseUserAgent.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@eudoroolivares2016 eudoroolivares2016 changed the title Edsc 3762 EDSC-3762: As a user, I want to download the downloader app if it is not available on my machine Jun 19, 2023
@macrouch
Copy link
Contributor

"Download for Linux", we should call out the .AppImage file, that is the only one that supports auto update once we get to that ticket. You should also provide links to all 3 linux files, .AppImage, .deb and .rpm

@macrouch
Copy link
Contributor

Screenshot 2023-06-23 at 12 58 11 PM The alignment of the apple logo here needs to be fixed

@eudoroolivares2016
Copy link
Contributor Author

To the point about the app logo on the modal Trevor had asked me to remove it entirely from the modal

static.config.json Outdated Show resolved Hide resolved
@eudoroolivares2016
Copy link
Contributor Author

Added links to the alternative Linux downloads (.deb and .rpm) promoted .AppImage to the top level

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes to package-lock.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an npm audit fix for the EDSC-3804 vulnerability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we already have a ticket to update libraries, they need to be updated in that ticket, not added on to a separate effort where we can't track that change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted package-lock switch. Tracking separately

/**
* Get the operating system of the client
* @param {String} userAgent - A string containing the navigator.userAgent from browser
* @return {String} The operating system from the client as a string being returned
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing but I think this would be:

Suggested change
* @return {String} The operating system from the client as a string being returned
* @return {(String|Null}} The operating system from the client as a string being returned

@macrouch macrouch dismissed jaybarra’s stale review July 3, 2023 16:07

Blocking merge and he is gone

@macrouch macrouch merged commit 270f49a into nasa:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants