EDSC-4234: Fix PR comments

nasa · Sep 20, 2024 · 5fa950d · 5fa950d
1 parent 0817aae
commit 5fa950d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 16 deletions.
diff --git a/static/src/js/components/AccessMethod/__tests__/SwodlrForm.test.js b/static/src/js/components/AccessMethod/__tests__/SwodlrForm.test.js
@@ -237,7 +237,7 @@ describe('SwodlrForm component', () => {
     describe('when updating individual granules UTM Zone Adjust', () => {
       test('updates utmZoneAdjust to `1 `calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 
@@ -285,7 +285,7 @@ describe('SwodlrForm component', () => {
 
       test('updates utmZoneAdjust to `-1` calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 
@@ -334,7 +334,7 @@ describe('SwodlrForm component', () => {
       test('updates utmZoneAdjust to `0` calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
 
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 
@@ -391,7 +391,7 @@ describe('SwodlrForm component', () => {
       test('updates MGRS to `1 `calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
 
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 
@@ -440,7 +440,7 @@ describe('SwodlrForm component', () => {
       test('updates MGRS to `-1 `calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
 
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 
@@ -489,7 +489,7 @@ describe('SwodlrForm component', () => {
       test('updates MGRS to `0 `calls onUpdateAccessMethod correctly', async () => {
         const { user, setGranuleList, onUpdateAccessMethod } = setup()
 
-        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-text' })
+        const advancedOptionsToggleButton = screen.getByRole('button', { name: 'collapse-panel' })
 
         await user.click(advancedOptionsToggleButton)
 

diff --git a/static/src/js/components/CollapsePanel/CollapsePanel.jsx b/static/src/js/components/CollapsePanel/CollapsePanel.jsx
@@ -49,7 +49,7 @@ export class CollapsePanel extends Component {
         <button
           className={buttonClassNames}
           type="button"
-          aria-label="collapse-text"
+          aria-label="collapse-panel"
           onClick={(event) => this.onToggleClick(event)}
           aria-controls="collapse-text"
           aria-expanded={open}

diff --git a/static/src/js/components/FormFields/AccessMethodRadio/AccessMethodRadio.jsx b/static/src/js/components/FormFields/AccessMethodRadio/AccessMethodRadio.jsx
@@ -129,7 +129,7 @@ export const AccessMethodRadio = ({
                     onMouseEnter={() => externalLink && setShowTooltip(true)}
                     onMouseLeave={() => externalLink && setShowTooltip(false)}
                   >
-                    <div className="access-method-radio__tool-tip">
+                    <div className="access-method-radio__tooltip">
                       <p className="mb-0">
                         {details}
                       </p>

diff --git a/static/src/js/components/FormFields/AccessMethodRadio/AccessMethodRadio.scss b/static/src/js/components/FormFields/AccessMethodRadio/AccessMethodRadio.scss
@@ -148,7 +148,7 @@
     font-size: 0.825rem;
   }
 
-  &__tool-tip {
+  &__tooltip {
     text-align: left;
   }
 

diff --git a/static/src/js/util/url/collectionsEncoders.js b/static/src/js/util/url/collectionsEncoders.js
@@ -212,7 +212,6 @@ const encodeRemovedGranules = (isOpenSearch, removedGranuleIds) => {
   return encodeGranules(isOpenSearch, removedGranuleIds)
 }
 
-// Decoders
 const decodedSelectedVariables = (pgParam) => {
   const { uv: variableIds } = pgParam
 
@@ -223,9 +222,7 @@ const decodedSelectedVariables = (pgParam) => {
 
 const decodedSwodlrDownload = (pgParam) => {
   const { swod: swodlrData } = pgParam
-  if (!swodlrData) {
-    return undefined
-  }
+  if (!swodlrData) return undefined
 
   return swodlrData
 }
@@ -548,7 +545,6 @@ export const decodeCollections = (params) => {
 
       // Decode swodlr subsettings on collections
       if (selectedAccessMethod && selectedAccessMethod.startsWith('swodlr')) {
-        // TODO some url valuse here have to be encoded
         swodlrData = decodedSwodlrDownload(pCollection)
       }
 
@@ -596,8 +592,6 @@ export const decodeCollections = (params) => {
         }
 
         if (swodlrData) {
-          // TODO convert these to numbers
-          // Const convertedSwodlrData = convertIntObj(swodlrData)
           projectById[collectionId].accessMethods = {
             [selectedAccessMethod]: {
               swodlrData