Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor test helper classes #500

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sanowl
Copy link

@sanowl sanowl commented Jun 16, 2024

Refactor and Enhance Test Helper Classes

Summary

This pull request refactors and enhances the test helper classes to improve readability, maintainability, and extend test coverage for various scenarios. The main changes include refactoring methods, adding comprehensive docstrings, and enhancing the skipIf decorator.

Changes

  1. Refactoring:

    • Split the test cases into smaller, focused methods.
    • Used self.assertIsInstance instead of direct class comparison for better readability.
  2. Enhancements:

    • Added more comprehensive docstrings.
    • Improved the naming and readability of methods.
    • Added pytest fixture placeholders for potential setup and teardown processes.
  3. Additional Features:

    • Included more tests for different HTML entities and encoding scenarios.
    • Made the skipIf decorator more Pythonic.

Testing

The changes have been tested locally and all test cases pass successfully. The new tests cover a wider range of scenarios, ensuring robustness and reliability.

Please review the changes and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant