Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apis.json #199

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Update apis.json #199

merged 1 commit into from
Aug 24, 2023

Conversation

KhurramJalil
Copy link
Contributor

Fixed #173 and #192 by updating both the broken links to correct URLs

Fixed nasa#173 and nasa#192 by updating both the broken links to correct URLs
@KhurramJalil
Copy link
Contributor Author

KhurramJalil commented Jul 4, 2023

@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES please review/approve/merge this PR as it fixes both the issues #173 and #192

Copy link
Contributor

@drbitboy drbitboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links worked for me.

@KhurramJalil
Copy link
Contributor Author

the links worked for me.

Thanks @drbitboy for reviewing the changes.

For me, "merging is blocked" i.e. I am not authorized to merge the changes of my PR into the nasa:gh-pages branch so can you please do the needful to merge my PR into the nasa:gh-pages branch?

@KhurramJalil
Copy link
Contributor Author

@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES Now that the PR has been reviewed/approved, can anyone of you please do the needful & merge this PR?

@KhurramJalil
Copy link
Contributor Author

@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES!

Now that @drbitboy has reviewed / approved the changes in this PR, can some authorized person please do the needful to merge it to the appropriate branch so the fix goes live?

For me "Merging is blocked" as I'm not authorized to merge this pull request.

1 similar comment
@KhurramJalil
Copy link
Contributor Author

@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES!

Now that @drbitboy has reviewed / approved the changes in this PR, can some authorized person please do the needful to merge it to the appropriate branch so the fix goes live?

For me "Merging is blocked" as I'm not authorized to merge this pull request.

@nwunderly
Copy link
Contributor

nwunderly commented Jul 22, 2023

My friend, I'm not sure anyone you're pinging has the ability or responsibility to merge anymore. I'm not a maintainer, just a contributor, and it appears that Justin (who had previously been maintaining this) has left NASA. Please check who you're actually trying to ping and whether they have any ability to do anything as you're bothering like ten people on a weekly basis.

@TKantz TKantz merged commit 1e28c37 into nasa:gh-pages Aug 24, 2023
@TKantz
Copy link
Contributor

TKantz commented Aug 24, 2023

Pull request approved and completed.

@KhurramJalil
Copy link
Contributor Author

Pull request approved and completed.

Thanks @TKantz

@KhurramJalil KhurramJalil deleted the patch-2 branch August 30, 2023 15:01
@Victor-Lockwood
Copy link

Victor-Lockwood commented Sep 11, 2023

It looks like these changes got reverted/overwritten at some point - the links are broken in prod again.

@KhurramJalil KhurramJalil restored the patch-2 branch September 16, 2023 04:26
@KhurramJalil KhurramJalil deleted the patch-2 branch September 16, 2023 04:32
@KhurramJalil
Copy link
Contributor Author

@TKantz @darith27 Can you please look into the issue mentioned by @Victor-Lockwood above where it seems like that my changes above for fixing both the broken links in file "assets/json/api.json" somehow got reverted or overwritten?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Links to SSCWeb
5 participants