-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apis.json #199
Update apis.json #199
Conversation
@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES please review/approve/merge this PR as it fixes both the issues #173 and #192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the links worked for me.
Thanks @drbitboy for reviewing the changes. For me, "merging is blocked" i.e. I am not authorized to merge the changes of my PR into the nasa:gh-pages branch so can you please do the needful to merge my PR into the nasa:gh-pages branch? |
@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES Now that the PR has been reviewed/approved, can anyone of you please do the needful & merge this PR? |
@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES! Now that @drbitboy has reviewed / approved the changes in this PR, can some authorized person please do the needful to merge it to the appropriate branch so the fix goes live? For me "Merging is blocked" as I'm not authorized to merge this pull request. |
1 similar comment
@jasonduley, @rubioJeffery, @evantayloryates, @danhammer, @jmhorn2015, @darith27, @drbitboy, @corincerami, @jnbetancourt, @nwunderly, @TKantz and @JustinGOSSES! Now that @drbitboy has reviewed / approved the changes in this PR, can some authorized person please do the needful to merge it to the appropriate branch so the fix goes live? For me "Merging is blocked" as I'm not authorized to merge this pull request. |
My friend, I'm not sure anyone you're pinging has the ability or responsibility to merge anymore. I'm not a maintainer, just a contributor, and it appears that Justin (who had previously been maintaining this) has left NASA. Please check who you're actually trying to ping and whether they have any ability to do anything as you're bothering like ten people on a weekly basis. |
Pull request approved and completed. |
Thanks @TKantz |
It looks like these changes got reverted/overwritten at some point - the links are broken in prod again. |
@TKantz @darith27 Can you please look into the issue mentioned by @Victor-Lockwood above where it seems like that my changes above for fixing both the broken links in file "assets/json/api.json" somehow got reverted or overwritten? |
Fixed #173 and #192 by updating both the broken links to correct URLs