Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10215: REPORT Logs Emitting Security Token in Clear Text #2191

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Nov 13, 2024

Overview

What is the feature/fix?

REPORT Logs Emitting Security Token in Clear Text

What is the Solution?

If the token exists, will obfuscate with ****. If it does not exist, will do nothing.

What areas of the application does this impact?

Logs across all apps

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 self-assigned this Nov 13, 2024
@jmaeng72 jmaeng72 marked this pull request as draft November 13, 2024 17:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.23%. Comparing base (b7d7a80) to head (5708396).

Files with missing lines Patch % Lines
...-app-lib/src/cmr/common_app/api/request_logger.clj 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
- Coverage   58.23%   58.23%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       71008    71009       +1     
  Branches     2024     2024              
==========================================
- Hits        41352    41350       -2     
- Misses      27767    27769       +2     
- Partials     1889     1890       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaeng72 jmaeng72 marked this pull request as ready for review November 13, 2024 19:32
@jmaeng72 jmaeng72 merged commit 0ecefa5 into master Nov 13, 2024
6 checks passed
@jmaeng72 jmaeng72 deleted the CMR-10215 branch November 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants