-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: migrating www components #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephiescastle
added
minor
Contains new features or enhancements
feature parity
Work needed to maintain consistency between our implementations of Explorer 1
feature
and removed
feature
labels
Jun 6, 2024
jamesray
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature parity
Work needed to maintain consistency between our implementations of Explorer 1
feature
minor
Contains new features or enhancements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Supports https://github.com/nasa-jpl/www/issues/26
header
store and filters used in WWWCaveats
Page...
components have not been migratedTODO: VUE3
to find remaining cleanup needed after the migrationInstructions to test
pnpm i
make vue-storybook
make vue-build
(should build without error)make nuxt-build
(should build without error)Tested in the following environments/browsers:
Operating System
Browser