Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: migrating www components #455

Merged
merged 26 commits into from
Jun 7, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jun 6, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports https://github.com/nasa-jpl/www/issues/26

  • Migrates and updates existing WWW Vue components to Explorer-1 Vue 3 components. Note: only a couple page components have been brought over.
  • Also migrates the header store and filters used in WWW
  • Updates Nuxt module to provide needed plugins

Caveats

  • Typescript is not configured perfectly, so typescript errors may occur
  • Components that use Apollo have not been completed
  • Most Page... components have not been migrated
  • Search the repo for string TODO: VUE3 to find remaining cleanup needed after the migration

Instructions to test

  1. pnpm i
  2. make vue-storybook
  3. You should see almost all of the WWW in the Storybook, and working
  4. make vue-build (should build without error)
  5. make nuxt-build (should build without error)

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added minor Contains new features or enhancements feature parity Work needed to maintain consistency between our implementations of Explorer 1 feature and removed feature labels Jun 6, 2024
@stephiescastle stephiescastle requested a review from jamesray June 7, 2024 17:49
@stephiescastle stephiescastle merged commit c27d652 into main Jun 7, 2024
1 check passed
@stephiescastle stephiescastle deleted the feature/porting-www-components branch June 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature parity Work needed to maintain consistency between our implementations of Explorer 1 feature minor Contains new features or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants