Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #26

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

lpsinger
Copy link
Member

Python 3.7 has reached end of life. See https://devguide.python.org/versions/.

@lpsinger lpsinger requested a review from dakota002 August 20, 2023 15:24
@lpsinger lpsinger marked this pull request as draft August 20, 2023 15:25
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.06%. Comparing base (52f5c7d) to head (3f8078d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   76.85%   76.06%   -0.80%     
==========================================
  Files           7        7              
  Lines         121      117       -4     
==========================================
- Hits           93       89       -4     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger
Copy link
Member Author

I marked this as a draft PR because I realized that we should probably wait until Python 3.7 is long past end of life.

@lpsinger lpsinger marked this pull request as ready for review July 18, 2024 15:12
Python 3.7 has reached end of life.
See https://devguide.python.org/versions/.
@lpsinger lpsinger merged commit 8cda2f3 into nasa-gcn:main Jul 18, 2024
17 of 18 checks passed
@lpsinger lpsinger deleted the drop-python-3.7 branch July 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant