Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point photometry notebook at new s3 bucket #385

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

troyraen
Copy link
Contributor

@troyraen troyraen commented Mar 6, 2025

The new s3 bucket 'irsa-fornax-testdata' has replaced the old bucket 'irsa-mast-tike-spitzer-data'. There is currently only one call to this bucket in all of the notebooks. This PR updates that call to point to the new bucket.

@troyraen troyraen self-assigned this Mar 6, 2025
@troyraen troyraen added infrastructure Issues about the infrastructure rather than content of the notebooks use case: forced photometry maintanence labels Mar 6, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@troyraen troyraen marked this pull request as ready for review March 6, 2025 00:58
@troyraen
Copy link
Contributor Author

troyraen commented Mar 6, 2025

When testing this, I found that this bucket is not actually being accessed. It seems that the SIA call reverts to downloading from "On-prem". Here is the relevant cell and the output:

>>> fornax_download(spitzer, access_url_column='sia_url', fname_filter='go2_sci',
                data_subdirectory='IRAC', verbose=False)
2025-03-06 00:57:05,315 | fornax | data region: us-east-1
2025-03-06 00:57:05,316 | fornax | data access mode: restricted
2025-03-06 00:57:05,529 | fornax | --- Downloading data from On-prem ---
...

I got the same result when I replaced the bucket name with an empty string, which I think verifies that it is not actually touching the bucket.

@bsipocz do you know any details about this code or its history? I don't even know who wrote it.

@bsipocz
Copy link
Member

bsipocz commented Mar 6, 2025

I can dig up the history, but so much has changed since that I'm not surprised it actually falling back to the on prem version.

I would say, merge the pr as is and there are other issues open for changing this dataset of the standard mosaics instead, so neither the bucket, nor the workarounds are needed.

@troyraen troyraen merged commit 30fd796 into main Mar 6, 2025
1 of 3 checks passed
@troyraen troyraen deleted the raen/switch-to-new-testdata-bucket branch March 6, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues about the infrastructure rather than content of the notebooks maintanence use case: forced photometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants