-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML classifier notebook cleanup and add new algorithms #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've look at part of this and have two comments below. I can look at the rest as well, but wanted to submit what I have now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through it with a very quick review, just looking at the code and big picture and without trying to run it. Most of the comments are take it or leave it type suggestions, or just discussion starters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked more, but stopped at section 2.5. I'll continue from there later, but here's my comments from this round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished reviewing. Just one more comment below. No blockers. Thanks!
Thanks for the comments, I've made changes as necessary. Some of the harder comments I have turned into issues to work on later. |
ML classifier notebook cleanup and add new algorithms 64a74ec
Things included in this PR
I don't think it makes sense to do a major review on this notebook, yet. I forsee another PR before it is ready for that, but wanted to break it up to better keep track of changes.
I would take suggestions on the current functions (ie., sigma clip_lightcurves, etc.) which take in
df_lc
as input, change something about it, and then return that samedf_lc
. I think @troyraen cautioned me about doing this, but I don't see good alternatives. I could imagine renaming the light curve that it returns, so that it takes in df_lc and returnsdf_lc_sigmaclip
. Thendf_lc_sigmaclip
is the input to the next function....and this goes on for a few functions....???FYI the sktime algorithm returns a lot of
FutureWarning
, I put in an issue to them about that.