Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: convert cuDF numpy types to python types in tests #987

Merged
merged 2 commits into from
Sep 18, 2024
Merged

test: convert cuDF numpy types to python types in tests #987

merged 2 commits into from
Sep 18, 2024

Conversation

LiamConnors
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@LiamConnors LiamConnors changed the title test: convert cuDF numpy types to python types test: convert cuDF numpy types to python types in tests Sep 17, 2024
@LiamConnors LiamConnors mentioned this pull request Sep 17, 2024
Closed
@MarcoGorelli
Copy link
Member

thanks Liam! I think if you add a pragma: no cover to those lines then this should pass (we don't test cudf in CI so we can't cover them yet)

@LiamConnors LiamConnors marked this pull request as ready for review September 17, 2024 22:05
@LiamConnors
Copy link
Member Author

thanks Liam! I think if you add a pragma: no cover to those lines then this should pass (we don't test cudf in CI so we can't cover them yet)

Thanks! Updated and the tests are passing now.

FBruzzesi
FBruzzesi approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiamConnors , let's ship it 👌

CatFunnycatGIF

@FBruzzesi FBruzzesi merged commit 9353ef9 into narwhals-dev:main Sep 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiamConnors @MarcoGorelli @FBruzzesi