docs: add dtypes check in utils/check_api_reference.py
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
FBruzzesi
commented
Sep 16, 2024
| @@ -28,9 +28,11 @@ | |||
| "item", | |||
| "scatter", | |||
| } | |||
| BASE_DTYPES = {"NumericType", "DType", "TemporalType"} | |||
There was a problem hiding this comment.
Shall we document these in the api reference page?
MarcoGorelli
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
thanks @FBruzzesi !
for numeric dtype, I think people can use .is_numeric, and set membership for the temporal ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist