Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert with raise #980

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Replace assert with raise #980

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9840e3c
replace assert with raise
raisadz Sep 15, 2024
666f8be
Merge remote-tracking branch 'upstream/main' into replace-assert-with…
raisadz Sep 15, 2024
e6e2f4a
no cover if block
FBruzzesi Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion narwhals/_arrow/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ def __getitem__(

# PyArrow columns are always strings
col_name = item[1] if isinstance(item[1], str) else self.columns[item[1]]
assert not isinstance(item[0], str) # help mypy # noqa: S101
if isinstance(item[0], str):
msg = "Can not slice with tuple with the first element as a str" # pragma: no cover
raise TypeError(msg) # pragma: no cover
FBruzzesi marked this conversation as resolved.
Show resolved Hide resolved
if (isinstance(item[0], slice)) and (item[0] == slice(None)):
return ArrowSeries(
self._native_frame[col_name],
Expand Down
Loading