Bug: add conversion from slice to array for selecting rows in pyarrow __getitem__
#978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Sep 15, 2024
FBruzzesi
reviewed
Sep 15, 2024
| from narwhals._arrow.series import ArrowSeries | ||
|
|
||
| # PyArrow columns are always strings | ||
| col_name = item[1] if isinstance(item[1], str) else self.columns[item[1]] | ||
| assert not isinstance(item[0], str) # help mypy # noqa: S101 |
There was a problem hiding this comment.
Fancy changing this from assert to a raise statement as a follow up?
the dangers of assert in python
TL;DR: assert is only run in debug mode, if you run python with the optimized flag, that will be skipped.
There was a problem hiding this comment.
Thanks for your comment @FBruzzesi , I replaced assert with raise in this PR #980
Please, note that the line never gets hit so # pragma: no cover is added
There was a problem hiding this comment.
Oh I see, thanks for pointing that out 👌! Let's move the conversation there anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
__getitem__fails with integer for column position #971Checklist
If you have comments or can explain your changes, please do so below.